-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improving QIIME 2 summary visualizations #72
Comments
This relates to #42, btw. |
Relates to ideas brought up in biocore#72.
@fedarko , thank you for raising this issue. Perhaps the easiest way to address this is to have inline text within the html below the figures describing the axes. |
@mortonjt Just to check, before I make more changes: these plots are switched around from in Tensorboard, right? That is, the top plot in the q2 summary ( (It looks like this is the case from the code below.) songbird/songbird/q2/_method.py Lines 69 to 75 in 3f9e6ec
I think reordering the plots to match Tensorboard's order + altering the axis labels (or at least |
I'm ok with swapping this plots. Thanks!
…On Wed, Sep 18, 2019, 4:49 PM Marcus Fedarko ***@***.***> wrote:
@mortonjt <https://github.com/mortonjt> Just to check, before I make more
changes: these plots are switched around from in Tensorboard, right? That
is, the top plot in the q2 summary (Loglikelihood) corresponds to the loss
plot in Tensorboard, and the bottom plot in the q2 summary (Cross
validation score) corresponds to the cv_error plot in Tensorboard?
(It looks like this is the case from the code below.)
https://github.com/biocore/songbird/blob/3f9e6ece79640e74a1dfe219e215849454818617/songbird/q2/_method.py#L69-L75
I think reordering the plots to match Tensorboard's order + altering the
axis labels (or at least Loglikelihood) to more closely match the
Tensorboard plots will be a good step. Will work on this later today,
pending your confirmation above.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#72?email_source=notifications&email_token=AA75VXNPQCFKWL6BEY62TLTQKKH5DA5CNFSM4IXV6XV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7BM47Y#issuecomment-532860543>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA75VXLOQNFASBQQVGKY5PLQKKH5DANCNFSM4IXV6XVQ>
.
|
As proposed in biocore#72.
Another item from biocore#72.
shouldn't cause the plots to get shifted to the right any more. also highlights the label ("Pseudo Q-squared:") in <strong> tags.
Thanks @mortonjt! Ok, I've made a few changes to the output summaries. also restructured + updated the README pretty heavily, see https://github.com/fedarko/songbird. will try to add links between the new summaries and new README sections tomorrow + get this PR sent in. Thanks for your help with this, and sorry to pester you with all of these updates—I think having this all be better documented will make a lot of people's times using Songbird easier, and I think that's something worth taking care of sooner rather than later :) |
@fedarko , this is awesome! Looking forward to seeing the PR! |
getting close! biocore#72
also updated the README summary screenshot accordingly. I think now is kosher to submit a pr for biocore#72!
This came up in #70. For some background here: I tried using these options back in July, couldn't make sense of the plots, and when I asked about it the response was opening #63 :) ...So I ended up just running Songbird outside of QIIME 2 for that project.
Since generating TF logging files through QIIME 2 sounds like it'd be a hassle, keeping these plots in the Q2 Songbird plugin (and improving them, to be usable by people who aren't intimately familiar with ML/Songbird/Tensorflow) would make sense.
So! Here's what the current output of
qiime songbird summarize-single
looks like (zoomed out to show the full display)—And here's the current output from
qiime songbird summarize-paired
—For reference, here's a screenshot of tensorboard showing a single run:
Ideas for improving the Q2 summary plots
Make the y-axes (
Loglikelihood
andCross validation score
) more descriptive, because the meanings aren't clear (I've talked to other people who also aren't sure how to interpret these).Cross validation score
plot corresponds to the topcv_error
Tensorboard plot?)Add text explaining how to interpret these plots
increasedecrease your--p-summary-interval
".These are cosmetic changes, mostly, so fixing them shouldn't be too difficult. I'd like to hear your thoughts on these ideas—can start working on a PR to resolve this immediately afterwards, either tonight or tomorrow.
The text was updated successfully, but these errors were encountered: