Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start using stdlib('c') in recipes #51185

Open
isuruf opened this issue Oct 6, 2024 · 5 comments
Open

Start using stdlib('c') in recipes #51185

isuruf opened this issue Oct 6, 2024 · 5 comments

Comments

@isuruf
Copy link
Contributor

isuruf commented Oct 6, 2024

conda-forge is using these to be explicit about the sysroot version and bioconda should too.

cc @mbargull

@martin-g
Copy link
Contributor

We tried to add it in one of the recipes but it failed to lint: #51295 (comment)
https://dev.azure.com/bioconda/bioconda-recipes/_build/results?buildId=71416&view=logs&j=eb1ca712-fec5-5d93-deb0-40983fe61f2f&t=c9ebc308-e058-58af-a4f4-866fa7649dbb&l=39

CC @mfansler

@aliciaaevans aliciaaevans self-assigned this Oct 16, 2024
@aliciaaevans
Copy link
Contributor

I am at a conference this week, but I will plan to take a look next week at what needs to be changed in the linting. (But if anyone else wants to submit a PR to bioconda-utils, please feel free.)

@jakirkham
Copy link

Tried looking at the link Martin included above, but it looks like the log expired. If someone has a fresh copy of the lint error, could you please add it here as a comment. That way we can get a better handle on the issue and how best to proceed

@mbhall88
Copy link
Contributor

Tried looking at the link Martin included above, but it looks like the log expired. If someone has a fresh copy of the lint error, could you please add it here as a comment. That way we can get a better handle on the issue and how best to proceed

Here is one from a recent attempt to use {{ stdlib('c') }} in #52356 (CI link https://github.com/bioconda/bioconda-recipes/actions/runs/12009842945/job/33475427794)

12:19:06 BIOCONDA ERROR Unexpected exception in lint_one
Traceback (most recent call last):
  File "/opt/mambaforge/envs/bioconda/lib/python3.10/site-packages/bioconda_utils/lint/__init__.py", line 614, in lint_one
    res = self.check_instances[check].run(recipe, fix)
  File "/opt/mambaforge/envs/bioconda/lib/python3.10/site-packages/bioconda_utils/lint/__init__.py", line 235, in run
    self.check_recipe(recipe)
  File "/opt/mambaforge/envs/bioconda/lib/python3.10/site-packages/bioconda_utils/lint/check_syntax.py", line 29, in check_recipe
    has_constraints = constraints.search(spec)
TypeError: expected string or bytes-like object
12:19:06 ASYNCIO DEBUG Using selector: EpollSelector
12:19:35 BIOCONDA DEBUG Found: LintMessage(recipe=Recipe "lrge", check='version_constraints_missing_whitespace', severity=<Severity.ERROR: 30>, title='Check raised an unexpected exception', body='', start_line=0, end_line=0, fname='meta.yaml', canfix=False)
The following problems have been found (visit https://bioconda.github.io/contributor/linting.html for details on the particular lints you get below.):

ERROR: meta.yaml:0: version_constraints_missing_whitespace: Check raised an unexpected exception

I took a look at the linting code for this lint in bioconda-utils. Essentially I think I a=have tracked it back to this jinja templating dictionary https://github.com/bioconda/bioconda-utils/blob/6240d31e706b91b4b217ab10305fb84aabd8a147/bioconda_utils/recipe.py#L138-L143

It seems easy enough on the surface to add something like "stdlib" : lambda x: "stdlib_{x}" but I don't know what the downstream effects of using that path in the recipe would be for bioconda-utils as a whole?

@jakirkham
Copy link

Seems the origin of the compiler line was effectively doing the same thing: bioconda/bioconda-utils@3cb4b1f

cc @epruesse (who added compiler and would have more insight into the linter code)

@aliciaaevans aliciaaevans removed their assignment Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants