Forward read_exact() as well as read(). #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we don't do this we end up using the generic read_exact method which is not necessarily optimal. This is especially when using a specialized Read implementation to go fast. See bincode-org#206
This was referenced Oct 10, 2017
|
Looks good, thanks! I'm also really interested in your specialized Read implementation. Is this the one that eschews bounds checking? |
|
@TyOverby It's at servo/webrender#1834. |
|
I just realized that this pull request alone will improve deserialization performance because we'll now be using the read_exact() implementation on &mut [u8] which is simpler than the default read() implementation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we don't do this we end up using the generic read_exact method
which is not necessarily optimal. This is especially when
using a specialized Read implementation to go fast.
See #206