-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test schema org #82
Test schema org #82
Conversation
Allowing for netCDF metadata on the web to be tested, e.g. URLs passed in like so:
result:
|
@jyucsiro I think you should (strictly) preface the "type" and "id" keys with @ symbols, such that they become "@type" and "@id". Without, they parse ok but with they are reserved in JSON-LD for the explicit definitions. On the identifier and license and keys, the "http://schema.org/" is not required. As we discussed on the call, it would be nice to split those GCMD keywords into an array... |
@@ -670,8 +670,10 @@ def load(afilepath): | |||
loader = netCDF4.Dataset | |||
else: | |||
raise ValueError('filepath suffix not supported: {}'.format(afilepath)) | |||
if not os.path.exists(afilepath): | |||
raise IOError('{} not found'.format(afilepath)) | |||
#Disable this check for now to allow URL input |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do both the hdf and netcdf APIs support loading from URI?
if so, we should just let them do that
is that what you are doing in this case? does it already work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't checked with HDF, but it seems to work with the netCDF APIs.
Yes, that's what I'm doing in this case - both local and from URLs (mainly netCDF files served through thredds).
Thanks @adamml. I'm using the rdflib-json-ld serializer (https://github.com/RDFLib/rdflib-jsonld). For some reason, for the example above, it doesn't add "type" and "id" with those symbols. Tinkering around https://json-ld.org/playground/, it looks like the output is a 'compacted' version, where "type" and "id" are implicitly equivalent to "@type" and "@id"? I tried getting the json-ld serializer to output with those '@' symbols but am not getting much success.
The issue will be then which namespace the identifier/license properties will come from. This link (https://developers.google.com/search/docs/data-types/dataset) lists license and identifier...
Yes, that would be good.
I've implemented this in nc2rdf for now. @marqh what do you think? |
Because you have {"@context": "http://schema.org",...} without the identifier/license properties, you are saying use the schema.org namespace. |
thank you for all the input, this looks good to go |
First cut.
See #80