[R4R] add levels parameter to depth ABCI query #639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ackratos
changed the title
unclezoro
approved these changes
Aug 5, 2019
|
get it. Go-sdk and http-ap will have change too. |
rickyyangz
reviewed
Aug 7, 2019
plugins/dex/client/rest/getdepth.go
Outdated
| @@ -13,7 +13,7 @@ import ( | |||
| "github.com/binance-chain/node/wire" | |||
| ) | |||
|
|
|||
| const allowedLimits = "5,10,20,50,100" | |||
| const allowedLimits = "5,10,20,50,100,500,1000" // consistent with mainsite: https://github.com/binance-exchange/binance-official-api-docs/blob/master/rest-api.md#market-data-endpoints | |||
There was a problem hiding this comment.
remove the comment
done
rickyyangz
reviewed
Aug 7, 2019
| @@ -13,7 +13,7 @@ import ( | |||
| "github.com/binance-chain/node/wire" | |||
| ) | |||
|
|
|||
| const allowedLimits = "5,10,20,50,100" | |||
| const allowedLimits = "5,10,20,50,100,500,1000" // consistent with mainsite: https://github.com/binance-exchange/binance-official-api-docs/blob/master/rest-api.md#market-data-endpoints | |||
| const defaultLimit = "100" | |||
|
|
|||
| // DepthReqHandler creates an http request handler to show market depth data | |||
There was a problem hiding this comment.
help fix the allowedLimitsA check
There was a problem hiding this comment.
help fix the
allowedLimitsAcheck
okay okay
darren-liu
requested changes
Aug 7, 2019
plugins/dex/abci.go
Outdated
| levelLimit := DefaultDepthLevels | ||
| if len(path) == 4 { | ||
| levelLimit, err := strconv.Atoi(path[3]) | ||
| if err != nil || levelLimit > MaxDepthLevels { |
There was a problem hiding this comment.
levelLimit should be larger than 0.
we should return err in the Log if the err is not nil.
| @@ -114,8 +115,9 @@ func showOrderBookCmd(cdc *wire.Codec) *cobra.Command { | |||
| if err != nil { | |||
| return err | |||
| } | |||
| levelsLimit := viper.GetInt(flagLevels) | |||
|
|
|||
There was a problem hiding this comment.
better check levelLimit here as well.
ackratos
force-pushed
the
max_depth
branch
2 times, most recently
from
9300411
to
a3271b9
Compare
rickyyangz
approved these changes
Aug 12, 2019
darren-liu
approved these changes
Aug 12, 2019
This was referenced Aug 12, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add levels parameter to depth ABCI query
@guagualvcha should change http-ap, but this change is compatible with current http-ap if he doesn't :)
WebSocket change: https://github.com/binance-chain/websocket-ap/pull/100
Rationale
websocket needs to snapshot more levels
Example
N/A
Changes
Preflight checks
make build)make test)make integration_test)Already reviewed by
...
Related issues
N/A
Pressure test: @ackratos @zjubfd see the results of depth api using larger limit, https://docs.google.com/spreadsheets/d/147NYJa38FRvXgMnKrUHIfarmg8FYylOmhpCPG9E3MCk/edit?usp=sharing