R4R: add fail ack handler for transferOut and add unit tests #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
abelliumnt
commented
Jun 16, 2020
•
abelliumnt
commented
- Remove try-catch in tokenhub
- Add fail ack handler for transferOut
- Add unit tests for transferOut fail ack handler
- Add unit test for MiniToken
abelliumnt
force-pushed
the
fail-ack-handler
branch
from
d237e5f
to
5905741
Compare
abelliumnt
changed the title
abelliumnt
force-pushed
the
fail-ack-handler
branch
from
5905741
to
45851c7
Compare
unclezoro
approved these changes
Jun 16, 2020
abelliumnt
force-pushed
the
fail-ack-handler
branch
from
45851c7
to
cc0af66
Compare
abelliumnt
pushed a commit
that referenced
this pull request
Jun 17, 2020
abelliumnt
pushed a commit
that referenced
this pull request
Jul 3, 2020
abelliumnt
pushed a commit
that referenced
this pull request
Jul 3, 2020
abelliumnt
pushed a commit
that referenced
this pull request
Jul 3, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.