Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R4R] Fix some bugs/issues in cosmos sdk #260

Merged
merged 5 commits into from
Jan 4, 2022
Merged

[R4R] Fix some bugs/issues in cosmos sdk #260

merged 5 commits into from
Jan 4, 2022

Conversation

forcodedancing
Copy link
Contributor

@forcodedancing forcodedancing commented Dec 15, 2021

Description

This pr fixes several issues/bugs reported in cosmos sdk.

Rationale

Several issues/bugs are reported in the official cosmos sdk. Because we are using a forked version of it, so we also need to address these issues in the repo.

Example

n/a

Changes

  • fix DerivePrivateKeyForPath to remove trailing slashes
  • fix the wrong check of delegation denom
  • fix an un-closed kvstore iterator usage
  • fix a bug in GetAccount when the address length is zero
  • fix nil error returned in UnmarshalJSON functions

crypto/keys/mintkey/mintkey.go Outdated Show resolved Hide resolved
@forcodedancing forcodedancing changed the title [R4R]: Fix some bugs/issues in cosmos sdk [R4R] Fix some bugs/issues in cosmos sdk Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants