Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R4R: hot fix for hard fork in get signers #172

Merged
merged 1 commit into from
Nov 21, 2019
Merged

R4R: hot fix for hard fork in get signers #172

merged 1 commit into from
Nov 21, 2019

Conversation

HaoyangLiu
Copy link
Contributor

@HaoyangLiu HaoyangLiu commented Nov 21, 2019 •
edited
Loading

Our change in stdTx getSigner results in hard fork.

panic: Failed to process committed block (49387831:B184FA9527DECA4EB8AD21441AF1C5424BB94AC1940F88B3C678BE306EE4B048): Wrong Block.Header.AppHash.  Expected 9F2DAA547207513C012F40D91C67417E697491926C22594E392CA09CE01738D0, got 388A6182067F05DE9BFC505426AAABADB2743A0724B6C81DF7E8984C9F9F2C00

goroutine 49027 [running]:
github.com/tendermint/tendermint/blockchain/v0.(*BlockchainReactor).poolRoutine(0xc000a16b60)
    /home/suyu/go/pkg/mod/github.com/binance-chain/[email protected]/blockchain/v0/reactor.go:399 +0x1bf0
created by github.com/tendermint/tendermint/blockchain/v0.(*BlockchainReactor).OnStart
    /home/suyu/go/pkg/mod/github.com/binance-chain/[email protected]/blockchain/v0/reactor.go:126 +0x84

https://explorer.binance.org/tx/21CCBAE89356D79EB4B9BCF406000B49F27C34E8B75B7B1D00C335ECA64AE790

@HaoyangLiu HaoyangLiu merged commit 67556cb into master Nov 21, 2019
@HaoyangLiu HaoyangLiu mentioned this pull request Nov 21, 2019
Merged
4 tasks
@forcodedancing forcodedancing deleted the hot-fix-signer branch May 18, 2022 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unclezoro unclezoro unclezoro approved these changes

@yutianwu yutianwu yutianwu approved these changes

@ackratos ackratos ackratos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HaoyangLiu @ackratos @yutianwu @unclezoro