R4R: upgrade tendermint to 0.32.3 #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
HaoyangLiu
force-pushed
the
tendermint-upgrade
branch
2 times, most recently
from
f57dcee to
1b578ab
Compare
HaoyangLiu
force-pushed
the
tendermint-upgrade
branch
from
29b0316 to
349ffb7
Compare
HaoyangLiu
changed the title
HaoyangLiu
requested review from
ackratos,
rickyyangz,
darren-liu,
unclezoro and
yutianwu
and removed request for
ackratos
ackratos
reviewed
Oct 30, 2019
| golang.org/x/text v0.3.2 h1:tW2bmiBqwgJj/UpqtC8EpXEZVYOwU0yG4iWbprSVAcs= | ||
| golang.org/x/text v0.3.2/go.mod h1:bEr9sfX3Q8Zfm5fL9x+3itogRgK3+ptLWKqgva+5dAk= | ||
| golang.org/x/time v0.0.0-20190308202827-9d24e82272b4/go.mod h1:tRJNPiyCQ0inRvYxbN9jk5I+vvW/OXSQhTDSoE431IQ= | ||
| golang.org/x/tools v0.0.0-20180221164845-07fd8470d635/go.mod h1:n7NCudcB/nEzxVGmLbDWY5pfWTLqBcC2KZ6jyYvM4mQ= |
There was a problem hiding this comment.
a lot of duplicates deps here for different revision. Could you please run a go mod tidy?
There was a problem hiding this comment.
I have tried go mod tidy. But it didn't work. Maybe I have to delete them manually.
ackratos
reviewed
Oct 30, 2019
| github.com/tendermint/iavl => github.com/binance-chain/bnc-tendermint-iavl v0.12.0-binance.1 | ||
| github.com/tendermint/tendermint => github.com/binance-chain/bnc-tendermint v0.29.1-binance.3.0.20190923114917-479a59a5dbd7 | ||
| github.com/zondax/ledger-cosmos-go => github.com/binance-chain/ledger-cosmos-go v0.9.9-binance.3 | ||
| golang.org/x/crypto => github.com/tendermint/crypto v0.0.0-20190823143015-45b1026d81ae |
ackratos
reviewed
Oct 30, 2019
go.mod
Outdated
| require ( | ||
| github.com/bartekn/go-bip39 v0.0.0-20171116152956-a05967ea095d | ||
| github.com/bgentry/speakeasy v0.1.0 | ||
| github.com/binance-chain/tss v0.1.0 |
There was a problem hiding this comment.
these 2 tss dependency LGTM
HaoyangLiu
force-pushed
the
tendermint-upgrade
branch
3 times, most recently
from
1ad6bb8 to
9863827
Compare
HaoyangLiu
force-pushed
the
tendermint-upgrade
branch
2 times, most recently
from
576ee4f to
538777e
Compare
HaoyangLiu
force-pushed
the
tendermint-upgrade
branch
from
538777e to
0d4442f
Compare
unclezoro
approved these changes
Nov 7, 2019
yutianwu
approved these changes
Nov 7, 2019
rickyyangz
approved these changes
Nov 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tendermint PR: bnb-chain/bnc-tendermint#111
Node PR: bnb-chain/node#666
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added entries in
PENDING.mdwith issue #rereviewed
Files changedin the github PR explorerFor Admin Use: