Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Tooz project locking in taskflowbackend? #1844

Open
mikkonie opened this issue Dec 1, 2023 · 0 comments
Open

Replace Tooz project locking in taskflowbackend? #1844

mikkonie opened this issue Dec 1, 2023 · 0 comments
Labels
app: taskflowbackend Issue in the taskflowbackend app environment Issues of dependencies, CI, deployment etc. feature Requested feature or enhancement tbd Comments wanted, spec/schedule/prioritization to be decided, etc.

Comments

@mikkonie
Copy link
Contributor

mikkonie commented Dec 1, 2023

The use of Tooz to handle project locking and unlocking in taskflowbackend is a remnant of the days when we used the separate SODAR Taskflow microservice for these transactions. In that case, a project object was not available so this made sense.

Now that these are integrated, I'm not sure if using this mechanism is required. Also, no other functionality in SODAR currently considers the taskflow locks for a project, so e.g. a sheet replacing operation can be triggered even while the project is "locked".

Perhaps it would be better to e.g. introduce a Project level locking mechanism within SODAR Core with relevant rules and APIs and use that here. The functionality could then be easily extended to other lockable features without the need for an extra library dependency and an external database (redis). Timing out the locks could be handled with a periodic celery job.

This would also enable sites other than SODAR to use such general-purpose locking. Not to mention this would go well with bihealth/sodar-core#24, which will be implemented soon anyway. This would make #1841 unnecessary as similar functionality would be implemented in SODAR Core.

..unless there's an advantage to Tooz I'm can't think of right now?

Something to consider, comments are welcome.

@mikkonie mikkonie added environment Issues of dependencies, CI, deployment etc. feature Requested feature or enhancement tbd Comments wanted, spec/schedule/prioritization to be decided, etc. app: taskflowbackend Issue in the taskflowbackend app labels Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app: taskflowbackend Issue in the taskflowbackend app environment Issues of dependencies, CI, deployment etc. feature Requested feature or enhancement tbd Comments wanted, spec/schedule/prioritization to be decided, etc.
Projects
None yet
Development

No branches or pull requests

1 participant