Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Getting parameters for EBfilter changes type from int to double #579

Closed
mbenary opened this issue Dec 12, 2024 · 0 comments · Fixed by #580
Closed

Getting parameters for EBfilter changes type from int to double #579

mbenary opened this issue Dec 12, 2024 · 0 comments · Fixed by #580

Comments

@mbenary
Copy link
Contributor

mbenary commented Dec 12, 2024

Describe the bug
When reading in parameters for EBFilter the type is changed from int to float. When calling EBFilter with these parameters, EBFilter will fail. In particular, this affects parameters -q (=min_mapq) and -Q (=min_baseq). The model.py for somatic_variant_filtration needs to be adapted to account for the type specificity of EBFilter.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: change type of parameters to adhere to specification of EBFilter bihealth/snappy-pipeline
1 participant
@mbenary