Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixes to .python-version, docs, .gitignore #8

Merged
merged 3 commits into from
Jul 6, 2023
Merged

fix: fixes to .python-version, docs, .gitignore #8

merged 3 commits into from
Jul 6, 2023

Conversation

gromdimon
Copy link
Contributor

First PR on the following cleanup issues:

  • Python version 3.10
  • There are additional files in my .idea/ folder, so I thought, that they shouldn't be pushed

Minor notes:

I found out, that I have no permissions on original repo. That is why I am pushing from fork :)

@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (aa0a237) 10.52% compared to head (cfc1ce8) 10.52%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main       #8   +/-   ##
=======================================
  Coverage   10.52%   10.52%           
=======================================
  Files           2        2           
  Lines          19       19           
=======================================
  Hits            2        2           
  Misses         17       17           
Flag Coverage Δ
backend 0.00% <ø> (ø)
frontend 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gromdimon gromdimon changed the title Setup fixes fix: fixes to .python-version, docs, .gitignore Jul 6, 2023
@holtgrewe holtgrewe marked this pull request as ready for review July 6, 2023 12:06
@holtgrewe
Copy link
Member

looks good, we cannot expect the image-build-push to work from forks

@holtgrewe holtgrewe merged commit 9cf42a4 into bihealth:main Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants