Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: more robust backend code and cleanup in tests (#354) #356

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

holtgrewe
Copy link
Member

No description provided.

@holtgrewe holtgrewe linked an issue Jan 2, 2024 that may be closed by this pull request
@holtgrewe holtgrewe enabled auto-merge (squash) January 2, 2024 11:26
Copy link

codecov bot commented Jan 2, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (e0e73ee) 75.00% compared to head (e9f0e80) 94.28%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #356       +/-   ##
===========================================
+ Coverage   75.00%   94.28%   +19.27%     
===========================================
  Files         172       53      -119     
  Lines        6865     1504     -5361     
  Branches     1513        0     -1513     
===========================================
- Hits         5149     1418     -3731     
+ Misses       1515       86     -1429     
+ Partials      201        0      -201     
Files Coverage Δ
backend/app/api/api_v1/api.py 75.75% <ø> (+21.59%) ⬆️
backend/app/api/api_v1/endpoints/acmgseqvar.py 100.00% <100.00%> (+30.61%) ⬆️
backend/app/api/api_v1/endpoints/bookmarks.py 100.00% <100.00%> (+24.39%) ⬆️
backend/app/api/api_v1/endpoints/caseinfo.py 100.00% <100.00%> (+26.53%) ⬆️
backend/app/api/api_v1/endpoints/clinvarsub.py 97.29% <ø> (+51.09%) ⬆️
backend/app/core/config.py 96.29% <ø> (+4.53%) ⬆️
backend/app/db/init_db.py 100.00% <ø> (+17.24%) ⬆️
backend/app/etc/utils.py 100.00% <ø> (+11.76%) ⬆️
backend/app/main.py 89.18% <100.00%> (+2.09%) ⬆️
backend/app/api/internal/endpoints/remote.py 92.77% <95.83%> (+30.74%) ⬆️

... and 121 files with indirect coverage changes

@holtgrewe holtgrewe merged commit 5306196 into main Jan 2, 2024
9 checks passed
@holtgrewe holtgrewe deleted the 354-cleanup-backend-test-code branch January 2, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup backend test code
1 participant