Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new SearchBar with vuetify Toolbars (#17) #34

Merged
merged 2 commits into from
Sep 4, 2023

Conversation

gromdimon
Copy link
Contributor

Tasks:

  • Modify Search bar to use vyetify toolbar
  • Add Search Bar in HeaderDetailPage
  • Test

Tasks for #16

  • Update containers
  • Update code

Tasks for #15

  • Implement VariantDetailPage
  • Add routes/stores/etc.
  • Test

@gromdimon gromdimon linked an issue Sep 4, 2023 that may be closed by this pull request
@gromdimon gromdimon enabled auto-merge (squash) September 4, 2023 07:57
@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Merging #34 (8074895) into main (0649cfe) will decrease coverage by 45.29%.
The diff coverage is 24.22%.

❗ Current head 8074895 differs from pull request most recent head 55bdd98. Consider uploading reports for the commit 55bdd98 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #34       +/-   ##
===========================================
- Coverage   84.07%   38.79%   -45.29%     
===========================================
  Files          16       30       +14     
  Lines         270     1026      +756     
  Branches       45      325      +280     
===========================================
+ Hits          227      398      +171     
- Misses         41      550      +509     
- Partials        2       78       +76     
Files Changed Coverage Δ
frontend/src/router/index.ts 40.00% <0.00%> (-10.00%) ⬇️
...end/src/components/VariantDetails/ScoreDisplay.vue 2.58% <2.58%> (ø)
.../components/VariantDetails/VariantConservation.vue 7.50% <7.50%> (ø)
frontend/src/api/mehari.ts 11.11% <11.11%> (ø)
frontend/src/stores/variantInfo.ts 11.76% <11.76%> (ø)
...end/src/components/VariantDetails/VariantTools.vue 22.00% <22.00%> (ø)
...nd/src/components/VariantDetails/BeaconNetwork.vue 25.00% <25.00%> (ø)
frontend/src/views/VariantDetailView.vue 25.00% <25.00%> (ø)
frontend/src/api/utils.ts 36.00% <27.27%> (-64.00%) ⬇️
frontend/src/components/VariantDetails/ClinVar.vue 30.76% <30.76%> (ø)
... and 13 more

@gromdimon gromdimon merged commit 6043aec into main Sep 4, 2023
@gromdimon gromdimon deleted the 15-implement-variant-details-page branch September 4, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Variant Details page
1 participant