Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: vega plot background colors in dark mode (#284) #337

Merged
merged 1 commit into from
Dec 22, 2023

Conversation

holtgrewe
Copy link
Member

No description provided.

@holtgrewe holtgrewe linked an issue Dec 22, 2023 that may be closed by this pull request
@holtgrewe holtgrewe enabled auto-merge (squash) December 22, 2023 10:52
Copy link

codecov bot commented Dec 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a61f864) 75.55% compared to head (3993d64) 84.51%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #337      +/-   ##
==========================================
+ Coverage   75.55%   84.51%   +8.95%     
==========================================
  Files         170       53     -117     
  Lines        6657     1576    -5081     
  Branches     1471        0    -1471     
==========================================
- Hits         5030     1332    -3698     
+ Misses       1436      244    -1192     
+ Partials      191        0     -191     

see 117 files with indirect coverage changes

@holtgrewe holtgrewe merged commit cb0cac1 into main Dec 22, 2023
9 checks passed
@holtgrewe holtgrewe deleted the 284-text-in-plots-is-not-readable-in-dark-mode branch December 22, 2023 10:56
@holtgrewe holtgrewe added this to the 0.3.0 milestone Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Text in plots is not readable in dark mode
1 participant