Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Close db connection on startup (#205) #212

Merged
merged 4 commits into from
Nov 15, 2023

Conversation

gromdimon
Copy link
Contributor

No description provided.

@gromdimon gromdimon changed the title fix: 205 sqlalchemy warnings in production fix: Close db connection on startup (#205) Nov 15, 2023
@gromdimon gromdimon enabled auto-merge (squash) November 15, 2023 11:00
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Merging #212 (606a440) into main (0ff3d21) will increase coverage by 7.74%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #212      +/-   ##
==========================================
+ Coverage   80.07%   87.82%   +7.74%     
==========================================
  Files         127       44      -83     
  Lines        3770      813    -2957     
  Branches      843        0     -843     
==========================================
- Hits         3019      714    -2305     
+ Misses        693       99     -594     
+ Partials       58        0      -58     

see 83 files with indirect coverage changes

@gromdimon gromdimon merged commit 1c2b913 into main Nov 15, 2023
9 checks passed
@gromdimon gromdimon deleted the 205-sqlalchemy-warnings-in-production branch November 15, 2023 11:05
@holtgrewe holtgrewe added this to the 0.3.0 milestone Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants