Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding async I/O, espec. for SV caller guessing #230

Merged
merged 7 commits into from
Oct 23, 2023
Merged

Conversation

holtgrewe
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Attention: 39 lines in your changes are missing coverage. Please review.

Comparison is base (dcc4152) 73.39% compared to head (38a1886) 73.89%.

❗ Current head 38a1886 differs from pull request most recent head 532382c. Consider uploading reports for the commit 532382c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #230      +/-   ##
==========================================
+ Coverage   73.39%   73.89%   +0.49%     
==========================================
  Files          18       21       +3     
  Lines        4342     4470     +128     
==========================================
+ Hits         3187     3303     +116     
- Misses       1155     1167      +12     
Files Coverage Δ
src/annotate/seqvars/csq.rs 68.99% <100.00%> (-0.07%) ⬇️
src/common/io/std.rs 100.00% <100.00%> (ø)
src/common/mod.rs 39.39% <ø> (ø)
src/annotate/strucvars/mod.rs 86.87% <94.64%> (+0.16%) ⬆️
src/common/io/tokio.rs 83.92% <83.92%> (ø)
src/common/noodles.rs 28.57% <28.57%> (ø)
src/main.rs 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@holtgrewe holtgrewe marked this pull request as draft October 23, 2023 10:34
@holtgrewe
Copy link
Contributor Author

It looks like the following must first be resolved. Otherwise, async files will not be written properly.

zaeleus/noodles#210

@holtgrewe holtgrewe marked this pull request as ready for review October 23, 2023 18:44
@holtgrewe holtgrewe merged commit 33c0e8e into main Oct 23, 2023
8 checks passed
@holtgrewe holtgrewe deleted the feat-async-io branch October 23, 2023 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant