Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: snake_case in REST APIs and rename /tx/csq to /seqvars/csq (#150) #189

Merged

Conversation

holtgrewe
Copy link
Contributor

No description provided.

@holtgrewe holtgrewe linked an issue Oct 2, 2023 that may be closed by this pull request
@holtgrewe holtgrewe enabled auto-merge (squash) October 2, 2023 13:39
@holtgrewe holtgrewe disabled auto-merge October 2, 2023 13:54
@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (9e14c09) 73.71% compared to head (232436e) 73.67%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #189      +/-   ##
==========================================
- Coverage   73.71%   73.67%   -0.04%     
==========================================
  Files          18       18              
  Lines        4249     4251       +2     
==========================================
  Hits         3132     3132              
- Misses       1117     1119       +2     
Files Coverage Δ
src/common.rs 59.45% <ø> (ø)
src/server/actix_server/mod.rs 0.00% <ø> (ø)
src/server/actix_server/seqvars_csq.rs 0.00% <0.00%> (ø)
src/server/mod.rs 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@holtgrewe holtgrewe enabled auto-merge (squash) October 2, 2023 14:22
@holtgrewe holtgrewe disabled auto-merge October 2, 2023 14:37
@holtgrewe holtgrewe merged commit e1021ed into main Oct 2, 2023
8 of 10 checks passed
@holtgrewe holtgrewe deleted the 150-use-snake_case-for-url-parameters-rather-than-kebab-case branch October 2, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use snake_case for URL parameters rather than kebab-case
1 participant