Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: problem with variants in multi-stop codon txs (#95) #96

Merged
merged 6 commits into from
Apr 6, 2023

Conversation

holtgrewe
Copy link
Contributor

This resolves issues with annotating p.Met1? but also others. See #95 well as biocommons/hgvs#651 for further details.

@holtgrewe holtgrewe linked an issue Apr 6, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Apr 6, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (4fccdb8) 88.81% compared to head (3d80d2f) 88.82%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #96   +/-   ##
=======================================
  Coverage   88.81%   88.82%           
=======================================
  Files          19       19           
  Lines        7983     7989    +6     
=======================================
+ Hits         7090     7096    +6     
  Misses        893      893           
Impacted Files Coverage Δ
src/mapper/altseq.rs 93.87% <100.00%> (+0.01%) ⬆️
src/mapper/assembly.rs 80.08% <100.00%> (+0.08%) ⬆️
src/mapper/variant.rs 90.84% <100.00%> (+0.03%) ⬆️
src/normalizer.rs 70.79% <100.00%> (+0.02%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@holtgrewe holtgrewe merged commit f25658c into main Apr 6, 2023
@holtgrewe holtgrewe deleted the 95-problem-with-annotating-pmet1-variants branch April 6, 2023 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem with annotating p.Met1? variants
1 participant