[BUG] Does not compile with MENU_LIST_MODE enabled TFT35 v3

[zech]

Description

I'm trying to compile the latest firmware from the master branch myself with VSCode/PIO. As soon as I enable list mode it does not compile and throws a lot of error messages like this:

TFT\src\User\Menu\Move.c:206:33: error: 'YGCODE_UP' undeclared (first use in this function); did you mean 'YGCODE_INC'?

It does seem like the renaming of variables was not done everywhere because it compiles fine with this option disabled.

Steps to reproduce

1. Change //#define MENU_LIST_MODE to #define MENU_LIST_MODE
2. Compile

Expected behavior
Should compile without errors and warnings.

Actual behavior
Compiles with some errors as described above about variables not existing. And a ton of warnings about missing braces around initializers.

TFT\src\User\Menu\PreheatMenu.c:5:26: warning: missing braces around initializer [-Wmissing-braces]
 MENUITEMS preheatItems = {

Additional Information

Configuration_h.zip

[guruathwal]

Fixed here #279

you can ignore the warnings, just compile again and they will disappear.

[guruathwal]

@zech please close the issue

[zech]

I can do when it's merged. Why isn't it so far?

[guruathwal]

BTT is slow when it comes to merging. until then you can download the source with the fix from this repository: https://github.com/guruathwal/BIGTREETECH-TouchScreenFirmware

[zech]

I see. The PR builds fine. Thanks. I'll close it then.

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.