Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

X_SLAVE_ADDRESS and E0_SLAVE_ADDRESS are the same #19

Closed
creamywhite opened this issue Aug 27, 2019 · 4 comments
Closed

X_SLAVE_ADDRESS and E0_SLAVE_ADDRESS are the same #19

creamywhite opened this issue Aug 27, 2019 · 4 comments

Comments

@creamywhite
Copy link

creamywhite commented Aug 27, 2019

In Configuration_adv.h:
#define X_SLAVE_ADDRESS 0 #define Y_SLAVE_ADDRESS 1 #define Z_SLAVE_ADDRESS 2 #define X2_SLAVE_ADDRESS 0 #define Y2_SLAVE_ADDRESS 0 #define Z2_SLAVE_ADDRESS 0 #define Z3_SLAVE_ADDRESS 3 //<--- #define E0_SLAVE_ADDRESS 0 //<--- #define E1_SLAVE_ADDRESS 0 #define E2_SLAVE_ADDRESS 0 #define E3_SLAVE_ADDRESS 0 #define E4_SLAVE_ADDRESS 0 #define E5_SLAVE_ADDRESS 0

It seems wrong to me. Previously it was like that:
#define Z3_SLAVE_ADDRESS 0 #define E0_SLAVE_ADDRESS 3

@The-slunk
Copy link

I noticed that it was changed also. I assumed it was a mistake and left E0 as 3 while compiling like an hour ago. Will report back after I get the board hooked up and tested.

@Chaotnix
Copy link

I noticed this also, seems somebody changed the wrong line. In the line above Z3 is set

to 3. I left E0 as 3 and Z3 as 0. This works flawlessly.

@thisiskeithb
Copy link
Contributor

I put in a PR to address the incorrect slave address for E0: #25

@creamywhite
Copy link
Author

I put in a PR to address the incorrect slave address for E0: #25

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants