Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistency in code convention #129

Closed
jaketae opened this issue Oct 8, 2021 · 0 comments · Fixed by #130
Closed

Consistency in code convention #129

jaketae opened this issue Oct 8, 2021 · 0 comments · Fixed by #130
Assignees
@jaketae
Labels
enhancement New feature or request

Comments

@jaketae
Copy link
Member

jaketae commented Oct 8, 2021

As discussed in #128, maintain code style consistency by setting up some basic formatters.

  • Makefile
  • pyproject.toml
  • setup.cfg

Benchmark HF transformers as point of reference.
@jaketae jaketae self-assigned this Oct 8, 2021
@jaketae jaketae added enhancement New feature or request Good First Issue Good for newcomers and removed Good First Issue Good for newcomers labels Oct 8, 2021
@jaketae jaketae mentioned this issue Oct 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jaketae jaketae

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Configure code style formatters bigscience-workshop/Megatron-DeepSpeed
1 participant
@jaketae