Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make sure contrasts is new style #191

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

ESCRI11
Copy link
Contributor

@ESCRI11 ESCRI11 commented Nov 26, 2024

Old datasets were not being initialized properly (e.g. public data GSE72056-scmelanoma.pgx).

Contrasts on this data set is numeric (non 0,1,-1) coded, which does not trigger the correct conversion. After passing through all the contrast check code, double check that the resulting contrasts table is not numeric, if so, pass through contrastAsLabels.

@ESCRI11 ESCRI11 requested a review from ivokwee November 26, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant