Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix RUV error on Lxgn data #190

Merged
merged 1 commit into from
Nov 25, 2024
Merged

fix RUV error on Lxgn data #190

merged 1 commit into from
Nov 25, 2024

Conversation

ivokwee
Copy link
Member

@ivokwee ivokwee commented Nov 25, 2024

Both SVA and RUV gave error on dataset.

  • SVA: num.sv was to high. remove adding +1. If error remains, we should limit num.sv with number or groups or such.
  • RUV: control genes were errorneously selected as those with sd=0. add sd>0 selection.

@ivokwee ivokwee requested a review from zitoa November 25, 2024 15:47
@zitoa zitoa self-assigned this Nov 25, 2024
@zitoa zitoa merged commit bae7b46 into main Nov 25, 2024
1 check failed
@zitoa
Copy link
Contributor

zitoa commented Nov 25, 2024

.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zitoa zitoa Awaiting requested review from zitoa

Assignees

@zitoa zitoa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ivokwee @zitoa