Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: STRF-11900 Drop node 18, add node 20, 22 #383

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Conversation

jairo-bc
Copy link
Contributor

@jairo-bc jairo-bc commented Aug 19, 2024

What? Why?

  • Breaking changed: Drop node 18
  • Add Node 20, 22 support
  • Updated several packages for semantic release
  • Bump paper handlebars [in progress]

How was it tested?

npm test


cc @bigcommerce/storefront-team

@jairo-bc jairo-bc requested a review from a team August 19, 2024 15:41
Copy link
Contributor

@huntario huntario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.nvmrc Outdated
20
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍹

20

Copy link
Contributor

@jordanarldt jordanarldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran npm install and npm test on both node 20 and node 22, works as expected. Approved! 💚

@jairo-bc jairo-bc merged commit 9b7a5a5 into master Aug 19, 2024
3 checks passed
Copy link
Contributor

🎉 This issue has been resolved in version 5.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants