Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STRF-8652 eliminate lodash from paper 2.x #212

Open
wants to merge 2 commits into
base: 2.x
Choose a base branch
from

Conversation

MaxGenash
Copy link
Contributor

What? Why?

  • Removed usages of lodash.
  • Updated +1 version of lab to support newer JS syntax (didn't try to update to the last version to avoid breaking changes in tests).

How was it tested?

npm run lint
npm run test

cc: @bigcommerce/storefront-team

helpers/contains.js Show resolved Hide resolved
helpers/money.js Show resolved Hide resolved
helpers/stylesheet.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
lib/fonts.js Show resolved Hide resolved
@MaxGenash MaxGenash force-pushed the STRF-8652_Eliminate_lodash_from_paper_2.x branch from d196177 to 77b2082 Compare September 22, 2020 16:25
@MaxGenash
Copy link
Contributor Author

Checked these changes on my dev store using a local Stapler and Cornerstone, works normally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants