Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(docs): update dropdown page to use new layout #739

Merged
merged 3 commits into from
Feb 28, 2022
Merged

feat(docs): update dropdown page to use new layout #739

merged 3 commits into from
Feb 28, 2022

Conversation

MariaJose
Copy link
Contributor

What?

Update dropdown page to use new layout.

Why?

Provide better experience to the user when reading the docs.

Screenshots

Screen Shot 2022-02-25 at 3 17 07 PM

@MariaJose MariaJose marked this pull request as ready for review February 25, 2022 21:30
@MariaJose MariaJose requested review from a team as code owners February 25, 2022 21:30
bc-andreadao
bc-andreadao requested changes Feb 25, 2022
View reviewed changes
Copy link
Contributor

@bc-andreadao bc-andreadao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a suggestion to be incorporated to the "Do's" section

bc-andreadao
bc-andreadao reviewed Feb 25, 2022
View reviewed changes
Copy link
Contributor

@bc-andreadao bc-andreadao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a spelling error on line 446 (see suggestion). Otherwise, good to go.

@MariaJose MariaJose merged commit cab8ede into bigcommerce:master Feb 28, 2022
@MariaJose MariaJose deleted the dropdown-page branch February 28, 2022 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bc-andreadao bc-andreadao bc-andreadao approved these changes

@chanceaclark chanceaclark chanceaclark approved these changes

@jorgemoya jorgemoya jorgemoya approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MariaJose @jorgemoya @chanceaclark @bc-andreadao