feat(docs): update panel page to use new layout #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgemoya
force-pushed
the
update-panel-page
branch
from
19f0ff7 to
81dd84f
Compare
jorgemoya
commented
Oct 8, 2021
| @@ -15,7 +15,7 @@ const panelProps: Prop[] = [ | |||
| }, | |||
| { | |||
| name: 'action', | |||
| types: 'ButtonProps & { text: string }', | |||
| types: 'ButtonProps & { text: string }', | |||
There was a problem hiding this comment.
I'm assuming this is what we wanted.
chanceaclark
reviewed
Oct 8, 2021
packages/docs/pages/panel.tsx
Outdated
| </Panel> | ||
|
|
||
| <Panel header="Implementation" headerId="implementation"> | ||
| <Text>The panel component is used to contain content in a structured format.</Text> |
There was a problem hiding this comment.
I think this might be a little redundant based on the above description 🤷 What do you think?
chanceaclark
approved these changes
Oct 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Update Panel page to use new layout.
Screenshots/Screen Recordings
Testing/Proof
N/A