Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(docs): add dark mode icon #560

Merged
merged 2 commits into from
Jul 14, 2021
Merged

feat(docs): add dark mode icon #560

merged 2 commits into from
Jul 14, 2021

Conversation

chanceaclark
Copy link
Contributor

What?

Adds dark mode favicon to the documentation.

Why?

QoL for your bookmarks/tabs.

Screenshots/Screen Recordings

Dark Mode:
Screen Shot 2021-07-13 at 14 35 24

Light Mode:
Screen Shot 2021-07-13 at 14 35 40

@chanceaclark chanceaclark requested review from a team as code owners July 13, 2021 19:46
tekstrand
tekstrand reviewed Jul 13, 2021
View reviewed changes
Copy link

@tekstrand tekstrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider running svg through optimizer. Code looks good though

https://jakearchibald.github.io/svgomg/

@chanceaclark
Copy link
Contributor Author

@tekstrand I already ran it through ImageOptim (uses SVGO) 😉

@tekstrand
Copy link

🤔 it seems to indicate more savings possible
559 bytes → 477 bytes 85.33%

@chanceaclark
Copy link
Contributor Author

I'm not entirely worried about 82 bytes if I've already ran it through an optimizer 🤷

@chanceaclark chanceaclark merged commit 898796e into bigcommerce:master Jul 14, 2021
@chanceaclark chanceaclark deleted the feat/dark-icon branch July 14, 2021 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tekstrand tekstrand tekstrand left review comments

@golcinho golcinho golcinho approved these changes

@deini deini deini approved these changes

@jorgemoya jorgemoya jorgemoya approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chanceaclark @tekstrand @jorgemoya @deini @golcinho