feat(component): add onOpen and onClose to Selects #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chanceaclark
approved these changes
Jun 10, 2021
icatalina
reviewed
Jun 21, 2021
|
|
||
| expect(onClose).toHaveBeenCalled(); | ||
|
|
||
| await waitForElement(() => queryByRole('listbox')); |
There was a problem hiding this comment.
queryBy* should only be used for querying when the element is not present: https://kentcdodds.com/blog/common-mistakes-with-react-testing-library#using-query-variants-for-anything-except-checking-for-non-existence
in this case we should use findByRole which does the wait for you:
const listbox = await findByRole('listbox');
expect(listbox).toBeInTheDocument();| }); | ||
|
|
||
| test('closing the MultiSelect triggers onClose', async () => { | ||
| const { getAllByRole, queryByRole } = render(MultiSelectMock); |
There was a problem hiding this comment.
It is recommended to use screen instead of using the output of render.
render(MultiSelectMock);
const button = screen.getAllByRole('button')[2];|
|
||
| test('closing the MultiSelect triggers onClose', async () => { | ||
| const { getAllByRole, queryByRole } = render(MultiSelectMock); | ||
| const button = getAllByRole('button')[2]; |
There was a problem hiding this comment.
It is better to target the actual button as opposed to use [2]. Not sure if it is feasible in this case, but it is better to use getByRole('button', { name: /text of the button/i })
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add
onOpenandonCloseprops to Selects.Why?
For some interactions on the Worksheet component (and other uses), I need to know when the dropdown has been opened or closed.
Testing/Proof
Unit tests and locally