Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(component): adds Counter component to bigdesign #371

Merged
merged 15 commits into from
Apr 20, 2020
Merged

feat(component): adds Counter component to bigdesign #371

merged 15 commits into from
Apr 20, 2020

Conversation

jordan-massingill
Copy link

@jordan-massingill jordan-massingill commented Apr 14, 2020 •
edited
Loading

WHAT

Adds a Counter component to the component library

TESTING

Manual testing

Screen Shot 2020-04-16 at 3 26 30 PMScreen Shot 2020-04-16 at 3 26 41 PM

@jordan-massingill jordan-massingill requested a review from a team April 14, 2020 22:12
@chanceaclark
Copy link
Contributor

We will probably want to remove the ticket number from the PR title.

@jordan-massingill jordan-massingill changed the title feat(component): CHP-6191 adds Counter component to bigdesign feat(component): adds Counter component to bigdesign Apr 15, 2020
jorgemoya
jorgemoya approved these changes Apr 16, 2020
View reviewed changes
Copy link
Contributor

@jorgemoya jorgemoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

chanceaclark
chanceaclark reviewed Apr 16, 2020
View reviewed changes
Copy link
Contributor

@chanceaclark chanceaclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also attached some screenshots to the PR.

packages/big-design/src/components/Counter/Counter.tsx Outdated Show resolved Hide resolved
packages/big-design/src/components/Counter/styled.ts Outdated Show resolved Hide resolved
packages/big-design/src/components/Counter/styled.ts Outdated Show resolved Hide resolved
packages/big-design/src/components/Counter/styled.ts Outdated Show resolved Hide resolved
chanceaclark
chanceaclark approved these changes Apr 20, 2020
View reviewed changes
Copy link
Contributor

@chanceaclark chanceaclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Great job on this!

@jordan-massingill jordan-massingill merged commit cff133e into bigcommerce:master Apr 20, 2020
@jordan-massingill jordan-massingill deleted the CHP-6191 branch April 20, 2020 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deini deini deini left review comments

@chanceaclark chanceaclark chanceaclark approved these changes

@jorgemoya jorgemoya jorgemoya approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jordan-massingill @chanceaclark @jorgemoya @deini