feat(component): restrict badges to use label props and style fixes #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgemoya
approved these changes
Feb 14, 2020
BREAKING CHANGE: Convert `<Badge>label</Badge>` to `<Badge label="label" />`.
chanceaclark
force-pushed
the
feat/badge
branch
from
c0cd69b to
2428492
Compare
deini
reviewed
Feb 14, 2020
| variant?: 'danger' | 'secondary' | 'success' | 'warning'; | ||
| } | ||
|
|
||
| export const Badge: React.FC<BadgeProps> = memo(({ className, style, ...props }) => <StyledBadge {...props} />); | ||
| export const Badge: React.FC<BadgeProps> = memo(({ className, style, label, ...props }) => ( | ||
| <StyledBadge {...props}>{label}</StyledBadge> |
There was a problem hiding this comment.
What do you think about doing a type check for the label? 🤔
There was a problem hiding this comment.
I think that's wise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Badgecomponent to use label prop.Textcomponent