feat(docs): use next instead of storybook #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chanceaclark
reviewed
Aug 2, 2019
| @@ -21,38 +21,43 @@ export class List extends React.PureComponent<ListProps> { | |||
| placement: 'bottom-start', | |||
| }; | |||
|
|
|||
| private listContainer = document.createElement('div'); | |||
| private listContainer: HTMLDivElement | undefined; | |||
There was a problem hiding this comment.
Could you simplify it to this?
Suggested change
| private listContainer: HTMLDivElement | undefined; | |
| private listContainer?: HTMLDivElement; |
| @@ -42,16 +42,19 @@ export class Modal extends React.PureComponent<ModalProps> { | |||
| static Body = StyledModalBody; | |||
| static Header = ModalHeader; | |||
|
|
|||
| private modalContainer: HTMLDivElement | undefined; | |||
There was a problem hiding this comment.
Suggested change
| private modalContainer: HTMLDivElement | undefined; | |
| private modalContainer?: HTMLDivElement; |
| @@ -22,14 +22,17 @@ export class Tooltip extends React.PureComponent<TooltipProps, State> { | |||
| visible: false, | |||
| }; | |||
|
|
|||
| private tooltipContainer = document.createElement('div'); | |||
| private tooltipContainer: HTMLDivElement | undefined; | |||
There was a problem hiding this comment.
Suggested change
| private tooltipContainer: HTMLDivElement | undefined; | |
| private tooltipContainer?: HTMLDivElement; |
chanceaclark
approved these changes
Aug 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get rid of
Storybookand start usingNext.jsfor our docs.Why
Storybook was becoming painfully slow.
SSRcompatible.packages/docsTODO in this PR:
TODO in following PRs: