feat(component): add description to Panel #1119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chanceaclark
approved these changes
Feb 1, 2023
| { | ||
| name: 'description', | ||
| types: ['string', 'React.ReactNode'], | ||
| description: 'Appends a description.', |
There was a problem hiding this comment.
🍹
Suggested change
| description: 'Appends a description.', | |
| description: 'Appends a description below the header and action.', |
Not exactly sure what you mean. 🤔 |
eugene-polev
approved these changes
Feb 2, 2023
|
Nevermind @jorgemoya I was under the impression that we could have a panel with an |
jorgemoya
force-pushed
the
add-panel-description
branch
from
d4dec53 to
cb01b6c
Compare
jorgemoya
force-pushed
the
add-panel-description
branch
from
cb01b6c to
b48d97b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add description to Panel component. Resolves #1109.
How?
I opted to allow the description a
stringor as aReactNode. This will allow the flexibility to include links in the description. Let me know if we want to showcase the "custom" ReactNode functionality.Should we include more do's and don'ts for this prop? @bigcommerce/product-design
Screenshots/Screen Recordings
Without description (remains the same):
Testing/Proof
Unit tests