Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added usehotkeys hook #9

Merged
merged 35 commits into from
Dec 5, 2023
Merged

Added usehotkeys hook #9

merged 35 commits into from
Dec 5, 2023

Conversation

anmol-kumar0815
Copy link
Collaborator

@anmol-kumar0815 anmol-kumar0815 commented Nov 16, 2023 •
edited
Loading

Fixes #3

  • Tested it locally using yalc, also verified with npm.

@anmol-kumar0815 anmol-kumar0815 self-assigned this Nov 16, 2023
anmol-kumar0815
anmol-kumar0815 commented Nov 16, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
Amaljith-K
Amaljith-K reviewed Nov 16, 2023
View reviewed changes
webpack.config.js Outdated Show resolved Hide resolved
@anmol-kumar0815
Copy link
Collaborator Author

@Amaljith-K _A Please review.

@neetogit-bot neetogit-bot bot assigned Amaljith-K and unassigned anmol-kumar0815 Nov 16, 2023
Amaljith-K
Amaljith-K reviewed Nov 17, 2023
View reviewed changes
Copy link
Contributor

@Amaljith-K Amaljith-K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anmol-kumar0815 _a

.eslintrc.js Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
rollup.config.js Outdated Show resolved Hide resolved
rollup.config.js Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
rollup.config.js Outdated Show resolved Hide resolved
@neetogit-bot neetogit-bot bot assigned anmol-kumar0815 and unassigned Amaljith-K Nov 17, 2023
@Amaljith-K
Copy link
Contributor

@anmol-kumar0815 a lot of your replies are misconceptions. Go through https://github.com/bigbinary/neeto-engineering-web/tree/main/Front-End-Guidelines/library-guidelines#managing-dependencies to get some of it clarified.

I'm re-assigning this work to @ittyjose _a to get it completed fast.

@neetogit-bot neetogit-bot bot assigned ittyjose and unassigned anmol-kumar0815 Nov 21, 2023
@deepakjosp
Copy link
Contributor

@deepakjosp _a

@deepakjosp
#3 - Updated eslint ignore files list.
cbb3e43
@deepakjosp
#3 - Omitted prettier and eslint write and checks from package.json a…
aacaa28 
…nd other configuration files.
@deepakjosp
#3 - Removed unnecessary peer dependencies and bundled it along with …
0976e10 
…the package
@deepakjosp
#3 - Added babel core package.
3714185
@deepakjosp
#3 - Removed hardsetting env value in rollup config
7aebe93
@deepakjosp
#3 - Removed unused plugin
d25fc17
@deepakjosp
#3 - Fixed the version mismatch issues of rollup and it's plugins
de7d576
@deepakjosp
Added aliases for constants and utils and fixed issues in rollup.config
238f387
@deepakjosp
#3 - Refactored constant util with absolute path.
e1dd279
@deepakjosp
#3 - Removed unnecessary file ref from eslintignore
bcae4c9
@deepakjosp
#3 - Set `@bigbinary/neeto/webpack-aliases-and-jsconfig-paths-should-…
0e991e3 
…be-in-sync` to off since we don't have jsconfig.json file in the path specified in the rule.
@deepakjosp
#3 - Fixed eslint dependencies version issues.
25316b5
@deepakjosp
#3 - Moved util functions to util file\.
e527fe3
@deepakjosp
Copy link
Contributor

@Amaljith-K _a please review.

@neetogit-bot neetogit-bot bot assigned Amaljith-K and unassigned deepakjosp Dec 4, 2023
@Amaljith-K
Copy link
Contributor

@deepakjosp _a please hand this over to @ajmaln when you are ready.

@neetogit-bot neetogit-bot bot assigned deepakjosp and unassigned Amaljith-K Dec 5, 2023
@deepakjosp
Copy link
Contributor

@ajmaln _a please review.

@neetogit-bot neetogit-bot bot assigned ajmaln and unassigned deepakjosp Dec 5, 2023
ajmaln
ajmaln approved these changes Dec 5, 2023
View reviewed changes
Copy link

@ajmaln ajmaln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deepakjosp _a Please check, rest LGTM

rollup.config.js Show resolved Hide resolved
@neetogit-bot neetogit-bot bot assigned deepakjosp and unassigned ajmaln Dec 5, 2023
@deepakjosp deepakjosp merged commit 1253eb9 into main Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Amaljith-K Amaljith-K Amaljith-K left review comments

@deepakjosp deepakjosp deepakjosp left review comments

@ajmaln ajmaln ajmaln approved these changes

Assignees

@deepakjosp deepakjosp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add useHotKeys hook
6 participants
@anmol-kumar0815 @Amaljith-K @deepakjosp @ajmaln @ittyjose @bot-bigbinary