Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release schedule #765

Closed
effigies opened this issue Aug 16, 2021 · 3 comments
Closed

Release schedule #765

effigies opened this issue Aug 16, 2021 · 3 comments

Comments

@effigies
Copy link
Collaborator

I think we're pretty close to a 0.14 release in the next week or so. Do we need to do a 0.13.2 first? And I believe only FitLins is going to be affected by the API breakages between 0.13 and 0.14, right, or should we check through the nipreps tools for ~= requirements?

cc @adelavega @shashankbansal6 @oesteban @mgxd and any other interested party

@adelavega
Copy link
Collaborator

I believe 0.13.2 should be safe to release right now.

I think these are the relevant changes on the maintenance branch.
#763
#762

@effigies
Copy link
Collaborator Author

effigies commented Aug 19, 2021

@adelavega maint/0.13.x is failing tests:

_____________________ test_load_synthetic_dataset[preproc] _____________________
[gw1] linux -- Python 3.8.11 /home/runner/work/pybids/pybids/virtenv/bin/python

synthetic = ('preproc', <bids.variables.entities.NodeIndex object at 0x7f72f187a7f0>)
Coverage.py warning: --include is ignored because --source is set (include-ignored)

    def test_load_synthetic_dataset(synthetic):
    
        param, index = synthetic
        # Runs
        runs = index.get_nodes('run')
        assert len(runs) == 5 * 2 * 3
        runs = index.get_nodes('run', {'task': 'nback'})
        assert len(runs) == 5 * 2 * 2
        variables = runs[0].variables
    
        if param == 'preproc':
            # non-exhaustive
            match = ['Cosine01', 'stdDVARS', 'RotZ', 'FramewiseDisplacement']
            sum_dense = 56
        else:
            match = ['trial_type', 'weight', 'respiratory', 'cardiac', 'stimA',
                     'stimB']
            sum_dense = 4
    
        for v in match:
>           assert v in variables.keys()
E           AssertionError: assert 'Cosine01' in dict_keys(['weight', 'trial_type', 'respiratory', 'cardiac', 'stimA', 'stimB'])
E            +  where dict_keys(['weight', 'trial_type', 'respiratory', 'cardiac', 'stimA', 'stimB']) = <built-in method keys of dict object at 0x7f72f0a786c0>()
E            +    where <built-in method keys of dict object at 0x7f72f0a786c0> = {'cardiac': <bids.variables.variables.DenseRunVariable object at 0x7f72f189c520>, 'respiratory': <bids.variables.varia...Variable object at 0x7f72f14f5f70>, 'stimB': <bids.variables.variables.DenseRunVariable object at 0x7f72f18909a0>, ...}.keys

bids/variables/tests/test_io.py:88: AssertionError

Looking into it, but maybe caused by #762, so might be obvious to you.

@effigies
Copy link
Collaborator Author

Ah, the problem is in f43a82c. PR in #767.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants