Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests / CI to model-zoo #23

Open
adelavega opened this issue May 3, 2022 · 5 comments
Open

Add tests / CI to model-zoo #23

adelavega opened this issue May 3, 2022 · 5 comments

Comments

@adelavega
Copy link
Contributor

No description provided.

@jdkent
Copy link

jdkent commented May 5, 2022

I could help tackle this, I would probably approach it by:

  • installing the environment specified by the pipfile in each of the directories
  • possibly datalad getting some of the files in the submodules if they are required (?)
  • executing the notebook to make sure it executes without error

@Remi-Gau
Copy link
Contributor

Remi-Gau commented Jun 2, 2022

Low hanging fruit

Validate all the model files against the schema.

Maybe with this?

https://python-jsonschema.readthedocs.io/en/stable/

@effigies
Copy link
Contributor

effigies commented Jun 2, 2022

Just import bsmschema and load it with the BIDSStatsModel model.

@Remi-Gau
Copy link
Contributor

Remi-Gau commented Jun 2, 2022

ah yes.
silly me 🙈

@Remi-Gau
Copy link
Contributor

Basic script I used on one of our repos

https://github.com/cpp-lln-lab/CPP_SPM/blob/dev/tools/validate_models.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@effigies @adelavega @Remi-Gau @jdkent