Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure entities in the derivatives pages are linked to the entities appendix #920

Closed
Remi-Gau opened this issue Nov 1, 2021 · 0 comments · Fixed by #936
Closed

Make sure entities in the derivatives pages are linked to the entities appendix #920

Remi-Gau opened this issue Nov 1, 2021 · 0 comments · Fixed by #936
Labels
derivatives formatting Aesthetics and formatting of the spec good first issue Good for newcomers

Comments

@Remi-Gau
Copy link
Collaborator

Remi-Gau commented Nov 1, 2021

But I realized that the other derivatives entities have no such links in the derivatives pages. Should we add them in another PR ?

I think that was just an oversight on my part. We should definitely link to the associated entity definition any time we reference an entity in the text.

Originally posted by @tsalo in #917 (comment)
@tsalo tsalo changed the title Make sure entities in the derivatives pages are linked to the enities appendix Make sure entities in the derivatives pages are linked to the entities appendix Nov 1, 2021
@tsalo tsalo added good first issue Good for newcomers derivatives formatting Aesthetics and formatting of the spec labels Nov 1, 2021
@sappelhoff sappelhoff mentioned this issue Nov 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
derivatives formatting Aesthetics and formatting of the spec good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[FIX] Add links from derivatives section to entity list sappelhoff/bids-specification
2 participants
@Remi-Gau @tsalo