-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
inconsistent style for the folder structure in the examples #807
Comments
As long as they look okay in HTML and PDF, I have no problem with the tree style. I think they're mostly going to be auto generated from schema, so the additional work should be minimal. |
wait... the examples are going to be auto-generated or the filename templates ? It is the latter, right? then in this case we would just need to make sure that all the examples have a non-tree style. |
I like the tree style pipes, but they break in the PDF, see #766 Although that issue does not seem to reduce legibility, so it may be fine to change all examples to use the tree style pipes. In any case, +1 for consistency. And I was not aware that we'd turn examples into schemas? |
I misread and thought we were talking templates... |
This might be useful for making tree-like templates: https://realpython.com/directory-tree-generator-python/ |
Thanks @tsalo |
@tsalo Let me know if you want me to generate the macro calls in the markdown files so that I am not completely useless on that front. |
I didn't get very far with the code, unfortunately. I haven't circled back to it yet, so if you are willing to take a crack at it, that would be awesome. Or anyone else who is interested too. |
Most examples folder structure in the specs are of the form:
But I realized that those in the qMRI page are more of the "tree" type:
This is a minor difference that it would be nice to standardize.
Even though it represents more work, I am tempted to make the "tree" version the default for the example.
The main reason is that it makes them even more visually distinct than the filename templates.
Any thoughts?
The text was updated successfully, but these errors were encountered: