Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INFRA] Need to adjust github-changelog-generator #559

Closed
sappelhoff opened this issue Aug 4, 2020 · 1 comment · Fixed by #594
Closed

[INFRA] Need to adjust github-changelog-generator #559

sappelhoff opened this issue Aug 4, 2020 · 1 comment · Fixed by #594
Labels
help wanted Extra attention is needed infrastructure

Comments

@sappelhoff
Copy link
Member

sappelhoff commented Aug 4, 2020

brought up by @franklin-feingold :

currently our changelog generator makes a new entry for each merged commit on our bids-specification repository. The problem comes up when we are working on a different branch (e.g., bepXXX) and merge commits into that branch --> then these commits would show up the changelog ALTHOUGH we'd actually only like commits merged into master to show up in the changelog

there is a setting to grant that only commits merged into master show up, ... we just need to figure out how to apply it.

cc @effigies @rwblair @tsalo

@franklin-feingold
Copy link
Collaborator

the github_changelog_generator parameter: release-branch should do it (https://github.com/github-changelog-generator/github-changelog-generator/wiki/Advanced-change-log-generation-examples)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants