Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How are subgroups to be dealt with in derivatives? E.g. patients versus controls #163

Open
chrisgorgo opened this issue Mar 5, 2019 · 8 comments

Comments

@chrisgorgo
Copy link
Contributor

How are subgroups to be dealt with? E.g. patients versus controls. Perhaps like this:

group-patients
group-controls

where all subjections would be

group-all

Originally posted by @robertoostenveld in https://github.com/_render_node/MDExOlB1bGxSZXF1ZXN0MjM4OTg3Njgy/timeline/more_items

@oesteban
Copy link
Collaborator

oesteban commented Mar 8, 2019

Back in September I added some about this in the Google Docs, but it seems it disappeared - #109 (comment)

EDIT ----

I proposed grp-label instead of group-label as an analogy to sub-label, e.g.:

grp-infants/
    anat/
        grp-infants_desc-average_T1w.nii.gz

could be a group-specific T1w template.

@chrisgorgo
Copy link
Contributor Author

Indeed handling group results have been removed from #109 to make the scope more manageable. Sorry this wasn't clear. This issue is to track this feature which hopefully can be covered by a new PR after #109 is merged.

@oesteban
Copy link
Collaborator

oesteban commented Mar 8, 2019

Yep, I think it disappeared before you even started the daunting task of #109. Anyways, that is irrelevant now, let's see whether we can build a neat implementation of groups :)

@TheChymera
Copy link
Collaborator

What about putting this information in a project-wide metadata file?
That would help make analysis blind, since researchers could keep the file unopened (or unwriten) up until the conclusion of the analysis. If groups are separated by directories or file names, it's going to be hard to even perform basic preprocessing QC in an unbiased fashion.

@rob-luke
Copy link
Member

Has this been addressed via the example participant.tsv file where there is a group column?

@CPernet
Copy link
Collaborator

CPernet commented Jun 20, 2021

I'd go for a simple solution - a recommended column in participants.tsv and possibly part of the name sub-control001, sub-patient001, ect ... I used that before, worked great

Having recommended naming would however help for pipelines (control is not the same as healthy, for instance you can have a patient group of interest vs a control patient group)

@oesteban
Copy link
Collaborator

What about putting this information in a project-wide metadata file?

This is readily available with BIDS "raw".

That would help make analysis blind, since researchers could keep the file unopened (or unwriten) up until the conclusion of the analysis. If groups are separated by directories or file names, it's going to be hard to even perform basic preprocessing QC in an unbiased fashion.

This is not a use case of this PR - albeit this is a good practice, BIDS (incl. Derivatives) already permits this be done easily. It's a choice of the researcher to encode things without obvious identifiers.

This PR is for encoding results that are group-wise in nature. Such as the custom template above.

a recommended column in participants.tsv

This is what @TheChymera recommended above, and perfectly doable ATM.

possibly part of the name sub-control001, sub-patient001, ect ... I used that before, worked great

Encoding variables within entity values is discouraged and definitely a bad idea. Best example is QC as Chris was mentioning.

That said, this suggestion does not solve the problem that analysis generates some interim results that derive from two or more different participants.

@omar-rifai
Copy link

omar-rifai commented Mar 14, 2022

Apologies for reviving an old post but I was wondering whether there was a followup on this discussion with regards to templates and other grouped intermediate results. I can not seem to find a clear consensus on how to proceed in this case.

@Remi-Gau Remi-Gau changed the title How are subgroups to be dealt with in derivatives? E.g. patients versus controls. Perhaps like this: How are subgroups to be dealt with in derivatives? E.g. patients versus controls Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants