-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"T1w" as keyword for <datatype>*CoordinateSystem #661
Comments
For those who are generally interested in coordinate systems in BIDS, I have created a wiki page that summarizes the status quo and also lists currently open questions and issues. --> https://github.com/bids-standard/bids-specification/wiki/Coordinate-Systems-for-MEG-EEG-iEEG It's a WIKI, so please add and/or correct items! |
iEEG user here: I think it would be very helpful to have T1w as a keyword for the CoordinateSystem because you generally end up localizing electrodes and mapping them to a T1w image. The current keywords essentially only account for if you ACPC align your T1w image before mapping ieeg coordinates to the image. However, there are cases where this description imo is insufficient. For example, if I want to map iEEG coordinates onto the T1w defined from FreeSurfer, it seems that a |
so are the electrode coordinate units then in "voxels"? or still in "mm", but mapped on the T1w image? Perhaps it'd make sense to do something like:
also, let's not forget what @robertoostenveld said in his comment here: #520 (comment) |
if it were expressed in voxels, it would also have to be made explicit whether voxel indices are counted with a 0-offset or with a 1-offset. I.e., is the first corner of the volume [0,0,0] or [1,1,1]? If it were expressed in mm, that would not be needed, as it is taken care of by the low-level NIFTI file definition. |
indeed, and for the MRI |
We typically express coordinates in mm, but mapped onto a T1 image. iEEGCoordinateUnits currently does not have the option for voxels. |
Taken from @robertoostenveld's comment: #520 (comment)
I think I agree with this, but it also renders WDYT? also, if you are reading this, please also check out bids-standard/bids-examples#215 |
This makes sense to me and imo is more informative then just "Other" which is currently how one encodes any arbitrary coordinate system for iEEG. Allowing for CT is also important since technically your ieeg coordinates are usually localized on that image. |
With the proposal from #661 (comment) you would encode Coming back to:
That wouldn't work for CT would it? Or is CT also measured in voxels? I get the impression that we should not support voxels for this after all ... and perhaps deprecate the only place where it's currently allowed (MRI |
I think that allowing Image and IntendedFor and having coordinates in mm units would suffice for iEEG (also for a CT in .bidsignore). In terms of processing, we get either mm coordinates or voxel indices from a CT.nii.gz and there is just 1 matrix transformation between these two. For consistency, it is not necessary to allow a new unit (voxels) for iEEG and mm/cm/m is sufficient. |
I am planning to open a PR soon that will address (1) an However, I have some questions/comments about the intro text to the table:
okay, +1 to not use voxels then, and I'll think about deprecating using "voxels" as a unit in the MRI |
see #700 |
+1 for allowing To avoid any ambiguity, we could limit this use case to the scanner-based coordinates, as defined in the
Examples: |
is the |
Well, it can be anything because it can be edited after acquisition. https://nifti.nimh.nih.gov/nifti-1/documentation/nifti1fields/nifti1fields_pages/qsform_brief_usage |
https://github.com/bids-standard/bids-examples/blob/23ab390fdfb4d38b3e3eeabdbd663e2ac09a16bc/eeg_ds000117/sub-01/eeg/sub-01_coordsystem.json#L2-L11
the
T1w
keyword seems to indicate that all coordinates must be interpreted in the light of the T1 weighted MRI image that is supplied with theIntendedFor
field.However, such a convention is currently not documented in Appendix 8: https://bids-specification.readthedocs.io/en/latest/99-appendices/08-coordinate-systems.html#coordinate-systems-applicable-to-meg-eeg-and-ieeg
The text was updated successfully, but these errors were encountered: