Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[joss review] Citing yt in the paper? #2

Closed
olebole opened this issue Aug 20, 2020 · 3 comments · Fixed by #6
Closed

[joss review] Citing yt in the paper? #2

olebole opened this issue Aug 20, 2020 · 3 comments · Fixed by #6

Comments

@olebole
Copy link

olebole commented Aug 20, 2020

Hi, I am reviewing the SALSA paper on Joss (openjournals/joss-reviews#2581). One question that arised for me is why the yt software is not cited? It seems to be used quite heavily.
@biboyd
Copy link
Owner

biboyd commented Aug 21, 2020

Yes that’s true and I actually thought the method paper was cited. Somehow it slipped through the cracks though.

I’ll add that later today as YT is definitely important to this project.

@biboyd
Copy link
Owner

biboyd commented Aug 21, 2020

Just added the YT method paper (https://ui.adsabs.harvard.edu/abs/2011ApJS..192....9T/abstract) to the list of references!

@biboyd biboyd closed this as completed Aug 24, 2020
@biboyd biboyd reopened this Aug 26, 2020
@biboyd biboyd linked a pull request Aug 26, 2020 that will close this issue
update yt ref in paper #6
Merged
@biboyd
Copy link
Owner

biboyd commented Aug 26, 2020

Realized I didn't mention YT in the paper still. Fixed that and YT method paper now included in references.

@biboyd biboyd closed this as completed in #6 Aug 26, 2020
@biboyd biboyd mentioned this issue Aug 26, 2020
Closed
40 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update yt ref in paper biboyd/SALSA
2 participants
@olebole @biboyd