Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++ backend parallelism bug #15

Open
jpeoples opened this issue Jun 8, 2024 · 0 comments
Open

C++ backend parallelism bug #15

jpeoples opened this issue Jun 8, 2024 · 0 comments

Comments

@jpeoples
Copy link

jpeoples commented Jun 8, 2024

There is a race condition in Filter.cpp. Because the algorithm runs in parallel, accessing the mpFeatureInformationMatrix->at() method is a bug, because it both reads and writes the underlying data, due to the lazy computation of the MI matrix.

It is possible there are other parallelism related bugs I haven't noticed, but I know that in preparing #13 , I had to disable parallelism in the R implementation in order to get the results to match between the two libraries.

I'll submit an issue to the R library as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant