Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Criterion is unable to generate line chart when BenchmarkId parameter is not number #810

Open
Jianqoq opened this issue Aug 23, 2024 · 5 comments

Comments

@Jianqoq
Copy link

Jianqoq commented Aug 23, 2024

No description provided.

@Jianqoq
Copy link
Author

Jianqoq commented Aug 23, 2024

for the line chart, when axis is a string or other type implemented display, line chart won't be generated

@grimerssy
Copy link

Seems logical to me. How should the parameters be placed on the line chart axis then? If you want to compare benchmarks with different inputs, I'd say that the violin plot is sufficient

@Jianqoq
Copy link
Author

Jianqoq commented Sep 9, 2024

for example, if I am doing a computation of N dimension array, the input is shape like [0, 1, 2], [0, 1], etc. I will want to see how the performance gose compare with other people's implementation. the Y axis value will be time

@grimerssy
Copy link

To do that you still can use the violin plot that is generated even if the BenchmarkId parameter is a string. And line chart is impossible to make with arbitrary sized arrays since there is no way to properly organise them on the axis. If it was possible there would be a way for you to tell if array A is as far away on the axis from array B as B is from C

@Jianqoq
Copy link
Author

Jianqoq commented Sep 10, 2024

The shape I pass to is a string, violin is not straight forward, people can't immediately understand it. line chart is more straight forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants