Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider replacing petgraph with a simpler data structure #2

Open
bhearsum opened this issue Jul 28, 2023 · 0 comments
Open

Consider replacing petgraph with a simpler data structure #2

bhearsum opened this issue Jul 28, 2023 · 0 comments
Labels
idea Something that is not yet fleshed out or decided

Comments

@bhearsum
Copy link
Owner

Petgraph was chosen as the data structure for Genome networks for two reasons:

  1. It has a lot of helpers when it comes to finding upstream and downstream nodes, connecting edges, etc.
  2. It let me sidestep any possible ownership issues with implementing a linked list manually

However, as the implementation got more complicated it felt like a strong possibility that petgraph may be hindering performance, overkill, or otherwise not the right tool for the job.

Before proceeding any further here, it would be ideal to some profiling to see if it is (or isn't) a hot spot.

If it is, looking for an alternative data structure libraries or biting the bullet and implementing the connections manually (f it's even feasible) may be worth considering.

@bhearsum bhearsum added the idea Something that is not yet fleshed out or decided label Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
idea Something that is not yet fleshed out or decided
Projects
None yet
Development

No branches or pull requests

1 participant