Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fw-main] :ua-product is chrome in node target #700

Open
arichiardi opened this issue Jun 20, 2018 · 2 comments
Open

[fw-main] :ua-product is chrome in node target #700

arichiardi opened this issue Jun 20, 2018 · 2 comments

Comments

@arichiardi
Copy link
Contributor

arichiardi commented Jun 20, 2018

Probably minor, but it seems that :ua-product is wrong in exception with :target :node.

I noticed this today:

 1. Unhandled clojure.lang.ExceptionInfo
   #object[ReferenceError ReferenceError: config is not defined]
   {:type :js-eval-exception,
    :error
    {:status :exception,
     :value
     "#object[ReferenceError ReferenceError: config is not defined]",
     :ua-product :chrome,
     :stacktrace
...

And figured I should report it 😉

@bhauman
Copy link
Owner

bhauman commented Jun 21, 2018

I think this is expected. This is used to tell the cljs.repl how to interpret a stacktrace and Node produces a Chrome-like stacktrace.

@arichiardi
Copy link
Contributor Author

Oh ok I think I was using :ua-product :node in lumo. Pretty sure the cljs compiler handles that but would not know what the difference is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants