Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong ANDROIDX_VERSION default version #6

Open
mkeology opened this issue Dec 30, 2022 · 0 comments
Open

wrong ANDROIDX_VERSION default version #6

mkeology opened this issue Dec 30, 2022 · 0 comments

Comments

@mkeology
Copy link

mkeology commented Dec 30, 2022

General summary of the issue.

current plugin.xml declares
preference name="ANDROIDX_VERSION" default="1.2.0"
which impacts dependency resolution to a lib that doesn't exist as it sets the ANDROIDX_VERSION:
implementation "androidx.legacy:legacy-support-v4:1.2.0"

This is actually a resulting impact when adding another cordova plugin replying on the ANDROIDX_VERSION which gets executed after.

https://androidx.tech/artifacts/legacy/legacy-support-v4/
Only version 1.0.0 exists anyways

Your Environment

  • Plugin version: 0.1.4
  • Platform: Ionic /capacitor/ cordova
  • OS version: Linux
  • Ionic Version (if using Ionic) : 6 (latest version)

Expected Behavior

no impact if plugin.xml has preference name="ANDROIDX_VERSION" default="1.0.0"

Actual Behavior

current plugin.xml declares
preference name="ANDROIDX_VERSION" default="1.2.0"
which impacts dependency resolution to a lib that doesn't exist :
implementation "androidx.legacy:legacy-support-v4:1.2.0"

Steps to Reproduce

Reproduce this issue; include code to reproduce, if relevant

  1. create ionic app
  2. cordova add android
  3. add cordova-plugin-local-notification-12
    add @awesome-cordova-plugins/local-notifications
    add cordova-plugin-badge-fix
    add cordova-plugin-device
    add cordova.plugins.diagnostic
  4. ionic cap sync etc
  5. build.gradle contains implementation "androidx.legacy:legacy-support-v4:1.2.0"

Context

build ionic app with capacitor

Debug logs

A final word, to say thank you, for all the work with this plugin.
I hope this issue helps towards it gaining success within the community.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant