You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
BTW @schmanu - this change is going to be incredibly painful since we have to change the BigNumber type from bignumberjs to ethers. I have already started porting this and will link a draft PR here. Some things we will have to deal with:
bignumber.js works on floating points as well, while the ethers one seems to only support integers.
This means that BigNumber.from("1.1") is no longer a thing.
We also have in some places (for NFTs) assertions that tokenID is not NaN and isInteger both of these functions don't exist on ethers.BigNumber (however once we get the floating point issue sorted out these checks may no longer be valid).
Documentation here: https://docs.ethers.io/v4/api-utils.html#ether-strings-and-wei
THis would mean we no longer need to unit test the functions as they are already tested elsewhere.
The text was updated successfully, but these errors were encountered: