Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement id checking when determining current_resource #57

Merged
merged 2 commits into from
Feb 6, 2014

Conversation

normanjoyner
Copy link
Contributor

When executing action :kill on a container, I realized I would have to supply the image, command and container name to successfully find and kill said container. I was planning on simply providing the id, and using that as the uid to determine which container to kill. This pull request allows current_resource matching to be short circuited if provided a valid container id.

  • It's worth noting that in its current state, most actions will require that image, command, and name are provided in the LWRP in order to successfully execute the action.

@bflad
Copy link
Contributor

bflad commented Feb 6, 2014

Nice, this is great addition. I think I misleadingly named those methods *_matches; some should have been named *_matches_if_exists. I'll merge this and refactor the other methods names appropriately.

bflad added a commit that referenced this pull request Feb 6, 2014
Implement id checking when determining current_resource
@bflad bflad merged commit 57db470 into sous-chefs:master Feb 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants